search

w3c / did-core

W3C Decentralized Identifier Specification v1.0
https://www.w3.org/TR/did-core/
Other
395 stars 93 forks source link

Ensure publicKeyMultibase values are valid. #807

Open msporny opened 2 years ago

msporny commented 2 years ago

This PR fixes the publicKeyMultibase values in the specification to ensure that they're correctly encoded.

Preview | Diff

msporny commented 2 years ago

zH3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV - does not work

Yes, exactly, that's the bug that this PR fixes?

selfissued commented 2 years ago

What are the specs that the existing and new values conform to and why the changes? There's not sufficient background in this PR to understand why these changes are being proposed or to validate that they're correct.

msporny commented 2 years ago

What are the specs that the existing and new values conform to and why the changes?

The spec is here:

https://w3c-ccg.github.io/did-method-key/

The old values were based on raw base58 values (no multicodec header), IIRC.

There's not sufficient background in this PR to understand why these changes are being proposed or to validate that they're correct.

The changes are being proposed because the current values are wrong. You can validate that they're correct by checking against multiple implementations that implement the publicKeyMultibase values.

OR13 commented 2 years ago

ahh, i think I must have copy pasted the wrong values lol... yes, this fix should be applied.