search

w3c / did-resolution

RELEASED DRAFT: Decentralized Identifier Resolution (DID Resolution) 0.2 Specification
https://w3c.github.io/did-resolution/
Other
14 stars 9 forks source link

Add error code for internalError #70

Closed aljones15 closed 2 years ago

aljones15 commented 2 years ago

This adds the error internalError with a suggested status code of 500.

peacekeeper commented 2 years ago

I agree with @kdenhartog that since DID Resolution doesn't necessarily use HTTP, HTTP status codes should be defined in the section about the HTTP(S) Binding: https://w3c-ccg.github.io/did-resolution/#bindings-https

E.g. that section says if the error is "notFound", then return HTTP status code 404.

But I also agree we could merge this now and then improve later.

aljones15 commented 2 years ago

@peacekeeper @kdenhartog I can't merge this PR, but I did take the suggestion. So let me know if this is good to go and thanks for the feedback.

peacekeeper commented 2 years ago

Looks good, thanks.