search

w3c / did-rubric

W3C Decentralized Characteristics Rubric v1.0
https://w3c.github.io/did-rubric/
Other
14 stars 16 forks source link

Added the github action file #48

Closed iherman closed 2 years ago

iherman commented 2 years ago

Setting up echidna for Rubric.

iherman commented 2 years ago

@jandrieu are you o.k. merging this?

jandrieu commented 2 years ago

I am.

So I did.

jandrieu commented 2 years ago

Looks like we have a problem. The CI process is failing.

https://github.com/w3c/did-rubric/actions/runs/1210046373

iherman commented 2 years ago

If you follow the action you get to:

https://github.com/w3c/did-rubric/runs/3535492088?check_suite_focus=true

which shows that there is an HTML validity issue that you should handle...

jandrieu commented 2 years ago

I see the set of errors, but I'm not finding the error in the code.

For example, "file:/home/runner/work/did-rubric/did-rubric.w3c/index.html":1473.9-1473.12: error: Element “li” not allowed as child of element “section” in this context. (Suppressing further errors from this subtree.)

However, in my local editor, using regex, I can't find a

followed by
  • (including allowing for arbitrary whitespace).

    Checking the code line 1473 doesn't have an

  • (nor does anything near it).

    In fact, the area of code that has all of the errors, is deep in a table with no

  • elements anywhere in sight.

    I've also manually scanned through all

  • elements, and they all seem to children in well-formed
      and
    • iherman commented 2 years ago

    @jandrieu I am looking at, for example:

    https://github.com/LegReq/did-rubric/blob/registry/index.html#L1053

    it has an <li> entry without an opening <ul> or <ol>, although there is a closing </ol> that probably messes up the HTML parser.

    Similar bugs may be elsewhere in the HTML file, I did not check all of them.

    jandrieu commented 2 years ago

    Ahh.. Thank you for finding that. I believe that is an error in a different PR that got pulled in and automatically applied, but must not have been in my local when I was looking.

    I'll get that fixed.

    -j

    On Fri, Sep 10, 2021, at 3:20 AM, Ivan Herman wrote:

    @jandrieu https://github.com/jandrieu I am looking at, for example:

    https://github.com/LegReq/did-rubric/blob/registry/index.html#L1053

    it has an <li> entry without an opening <ul> or <ol>, although there is a closing </ol> that probably messes up the HTML parser.

    Similar bugs may be elsewhere in the HTML file, I did not check all of them.

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/w3c/did-rubric/pull/48#issuecomment-916796657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNTT65APVTRMWBNJR5WV3UBHLWFANCNFSM5C26S5YQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

    -- Joe Andrieu, PMP @.*** +1(805)705-8651 http://blog.joeandrieu.com