search

w3c / dxwg

Data Catalog Vocabulary (DCAT)
https://w3c.github.io/dxwg/dcat/
Other
150 stars 47 forks source link

Providing a svg for the main class diagram #1382

Closed riccardoAlbertoni closed 3 years ago

riccardoAlbertoni commented 3 years ago

This PR addresses issue #1294 by providing a manipulable drawio diagram and an SVG diagram for the DCAT UML class.

As a side comment, even before this PR, the diagrams we are including in DCAT are made from different tools and have a different look and feel.

preview: https://rawgit.com/w3c/dxwg/dcat-issue-1294/dcat/index.html#dcat-scope

riccardoAlbertoni commented 3 years ago

Thanks, @andrea-perego, for your suggestions. I have accepted all and made some changes to keep the references to the figure consistent. If there are no other things you consider problematic, Please consider giving your approval to this PR.

andrea-perego commented 3 years ago

Thanks, @andrea-perego, for your suggestions. I have accepted all and made some changes to keep the references to the figure consistent. If there are no other things you consider problematic, Please consider giving your approval to this PR.

@riccardoAlbertoni , I think it may be worth changing accordingly also the name of the .drawio file.

riccardoAlbertoni commented 3 years ago

Thanks, @andrea-perego, for your suggestions. I have accepted all and made some changes to keep the references to the figure consistent. If there are no other things you consider problematic, Please consider giving your approval to this PR.

@riccardoAlbertoni , I think it may be worth changing accordingly also the name of the .drawio file.

Right, I've updated the name of the .drawio file. Thanks.

dr-shorthair commented 3 years ago

Should Figure 6 (Qualified Relations) be updated as well?

riccardoAlbertoni commented 3 years ago

Should Figure 6 (Qualified Relations) be updated as well?

I have updated it. It does not harm to have all the diagrams for DCAT with the same look and feel; also, I have taken the chance to change a 'dct:relation', which was not yet converted in dcterms.

Instead, I suggest not to update the one on Schema.org, fig 7, as it would take too many energies, and I think we'd better spend those energies closing other issues.

agbeltran commented 3 years ago

@riccardoAlbertoni thanks for this, it is looking good - it would be nice to update fig 7 too, as it looks inconsistent now - have you shared the link to draw.io? we can do the new figure and updates collaboratively

riccardoAlbertoni commented 3 years ago

@riccardoAlbertoni thanks for this, it is looking good - it would be nice to update fig 7 too, as it looks inconsistent now - have you shared the link to draw.io? we can do the new figure and updates collaboratively

A separate issue is created for Fig 7, see https://github.com/w3c/dxwg/issues/1383

aidig commented 3 years ago

Seeing that the original UML class diagram was created in Sparx EA, might it have been (or still could be an) an idea to export the diagram from Sparx EA as .wmf file and then convert that to .svg?