search

w3c / dxwg

Data Catalog Vocabulary (DCAT)
https://w3c.github.io/dxwg/dcat/
Other
139 stars 55 forks source link

Fix typo in Example 15 #1463

Closed andrea-perego closed 2 years ago

andrea-perego commented 2 years ago

Addresses https://github.com/w3c/dxwg/issues/1459

riccardoAlbertoni commented 2 years ago

We might want to propagate the change in the rdf example files available under the directory dcat/examples and in the text explaining example 15.

Moreover, I have noticed that in the REC we have used three different name spaces for example URIS: https://example.org/, http://example.org/, and https://dcat.example.org/ Perhaps we should consider to use one only. In case, do we want to deal with the example namespace uniformity in a separate issue?

andrea-perego commented 2 years ago

We might want to propagate the change in the rdf example files available under the directory dcat/examples and in the text explaining example 15.

Could you please take care of it, @riccardoAlbertoni ?

Moreover, I have noticed that in the REC we have used three different name spaces for example URIS: https://example.org/, http://example.org/, and https://dcat.example.org/ Perhaps we should consider to use one only. In case, do we want to deal with the example namespace uniformity in a separate issue?

Yes, I think we'd better open a new issue on it.

andrea-perego commented 2 years ago

I agree with Riccardo's comments - line 4020 needs the same change: <code>https://example.org/PoelenJorritHID</code> to <code>https://dcat.example.org/PoelenJorritHID</code>

Thanks, @agbeltran . Just fixed via https://github.com/w3c/dxwg/pull/1463/commits/3b6f1f377ad330b1e52df3584419beb000c221f9

andrea-perego commented 2 years ago

I agree with Riccardo's comments - line 4020 needs the same change: <code>https://example.org/PoelenJorritHID</code> to <code>https://dcat.example.org/PoelenJorritHID</code>

Thanks, @agbeltran . Just fixed via 3b6f1f3

@agbeltran , could you please check if your happy with this revision, and add your review?