w3c / epub-tests

Test repository for EPUB3, maintained by the EPUB3 WG
https://w3c.github.io/epub-tests/
Other
22 stars 20 forks source link

Remove question marks from the tables #272

Closed iherman closed 1 year ago

iherman commented 1 year ago

This PR proposes a tiny change in the test result tables: replace the '?' character with a simple space. The color coding of the cells, as well as the text labels ('pass', 'fail', 'n/a') does not make it necessary to use the '?' character, and an empty cell just does it. On the other hand, I found the large number of '?' characters tiring to the eye...

mattgarrish commented 1 year ago

Why not just put in a label like 'unverified' and give it a background style? Empty holes in the table are equally distracting, especially when the changing row colours come through. It would make the result part of the table more uniform if there were a consistent set of styles and labels to every cell.

(I'd probably use the yellow background for the unverified cells and change n/a to grey, as it's common to have inapplicable stuff diminished, not highlighted.)

iherman commented 1 year ago

Why not just put in a label like 'unverified' and give it a background style? Empty holes in the table are equally distracting, especially when the changing row colours come through. It would make the result part of the table more uniform if there were a consistent set of styles and labels to every cell.

With the number of cells horizontally, the term "unverified" will be too long and will probably be broken into lines. Any term with max four characters?

(I'd probably use the yellow background for the unverified cells and change n/a to grey, as it's common to have inapplicable stuff diminished, not highlighted.)

I like that, I will do this color change

mattgarrish commented 1 year ago

Any term with max four characters?

To do?

(That's a tough restriction!)

Edit: "Todo" is also an acceptable word by some sources if you don't want the space.

iherman commented 1 year ago

Any term with max four characters?

To do?

(That's a tough restriction!)

:-)

Edit: "Todo" is also an acceptable word by some sources if you don't want the space.

I will run with that for now.

iherman commented 1 year ago

Ok. I have made the changes. There is no preview in the PR, but here is how it looks like now (screen dump on my machine):

Screenshot 2023-01-18 at 17 33 56
mattgarrish commented 1 year ago

LGTM!