search

w3c / fxtf-drafts

Mirror of https://hg.fxtf.org/drafts
https://drafts.fxtf.org/
Other
68 stars 49 forks source link

[motion-1] The syntax of "offset" shorthand is out-of-date #515

Open BorisChiou opened 1 year ago

BorisChiou commented 1 year ago

After the updating of offset-position and offset-path, we have the offset transform (and create stacking context) only when offset-path is not none. offset-position is used only when offset-path functions don't specify the offset starting position.

So the current syntax of offset shorthand is out-of-date.

[ <'offset-position'>? [ <'offset-path'> [ <'offset-distance'> || <'offset-rotate'> ]? ]? ]! [ / <'offset-anchor'> ]?

The exclamation point (!) doesn't make sense now. It's not necessary to have offset-position if we don't specify offset-path. Perhaps we should always specify offset-path, and move offset-position together with offset-anchor or other places?

SebastianZ commented 6 months ago

@BorisChiou It looks like browsers ended up implementing the current syntax. So it's probably too late to move <'offset-position'> together with <'offset-anchor'>. Though maybe an HTTP archive check could proof the opposite.

Do I understand you correctly that you want to change the syntax to the following?

<'offset-path'> [ <'offset-distance'> || <'offset-rotate'> ]? [ / [ <'offset-anchor'> || <'offset-position'> ]?

Sebastian

BorisChiou commented 6 months ago

Yeah! The syntax you provided,

<'offset-path'> [ <'offset-distance'> || <'offset-rotate'> ]? [ / [ <'offset-anchor'> || <'offset-position'> ]?

looks much better than the original one because offset-position is ignored if we don't have an valid offset-path.

The design idea of the current shorthand syntax is because offset-position may create a stacking context, and it could be used independently. However, we change its meaning in 2023 but we probably forgot to change the shorthand at the same time.

SebastianZ commented 6 months ago

Ok, so this needs a check for whether the change is web-compatible, then. https://chromestatus.com/metrics/css/timeline/popularity/543 indicates a quickly growing percentage of pages using offset.

Anyone able to do a more granular HTTP Archive query to get numbers on this? What's needed is a check on usages of <'offset-position'> value usages in the offset shorthand property, or more precisely, the combination <'offset-position'> <'offset-path'>.

Sebastian