w3c / gamepad

Gamepad
https://w3c.github.io/gamepad/
Other
139 stars 49 forks source link

Editorial: Fix a few inconsistencies in "GamepadButton Interface" #122

Closed kri closed 4 years ago

kri commented 4 years ago

This PR is relatively straightforward. All in all, there were only a couple of editorial changes, all of which in the GamepadButton Interface section:


The following tasks have been completed:

Implementation commitment:


Preview | Diff

marcoscaceres commented 4 years ago

Can I be a pain and ask you to change the “zero” to 0. That better matches the checks.

marcoscaceres commented 4 years ago

Marked as non substantive for IPR from ash-nazg.

kri commented 4 years ago

You're not being a pain at all. :) My reasoning to go for "zero" when given the choice was really just based on the recommendation to spell out integers below 10 in English. Given the technical context, I can see how writing 0 might be favorable here, so I'll happily comply.

I went ahead and force-pushed your requested change. Let me know if there's anything else I can do.

marcoscaceres commented 4 years ago

Thanks @kri. All review feedback is always greatly appreciated.