search

w3c / gamepad

Gamepad
https://w3c.github.io/gamepad/
Other
139 stars 49 forks source link

Add the xr-standard mapping type #146

Closed toji closed 3 years ago

toji commented 3 years ago

This was reported in https://github.com/immersive-web/webxr-gamepads-module/issues/35

This property was already defined in the WebXR Gamepad Module, but since WebIDL does not allow for partial enums we ended up repeating the enum with the new value in that spec. This has apparently caused some tooling issues as there are now two conflicting copies of the same enum within the W3C spec library.

I would love it if there was a way to keep this value better scoped to the relevant spec, but lacking that it seems best to lift this up into the main gamepad spec with links off to the definition of the mapping in the WebXR spec and a note that it is reserved for use by that spec.

Preview | Diff

dontcallmedom commented 3 years ago

https://github.com/heycam/webidl/issues/184 is where partial enums have been proposed for reference

toji commented 3 years ago

I believe all the outstanding comments have been addressed at this point. Anything else that should be looked at before merging?

marcoscaceres commented 3 years ago

Ok to merge this and we can deal with the hard links after... I need to check why the bots are stuck tho.

marcoscaceres commented 3 years ago

Ok, merged. @toji, let me know once stuff on your side gets merged and I'll fix up the links.

toji commented 3 years ago

Thanks! Just merged https://github.com/immersive-web/webxr-gamepads-module/pull/36

marcoscaceres commented 3 years ago

Awesome, thanks for the update!