Enhance Gamepad interface description for Touch

w3c / gamepad

Gamepad

https://w3c.github.io/gamepad/

Other

138 stars 49 forks source link

Enhance Gamepad interface description for Touch #168

Closed bradleyneedham closed 8 months ago

bradleyneedham commented 1 year ago

Closes #167

The following tasks have been completed:

[ ] Modified Web platform tests (link to pull request)

Implementation commitment:

[ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=)
[x] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=1143942#c14)
[ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=)

Standards positions:

[x] Webkit (https://github.com/WebKit/standards-positions/issues/110)
[ ] Gecko (https://github.com/mozilla/standards-positions/issues/724)

Resources:

[x] Explainer (https://github.com/bradleyneedham/gamepad/blob/multitouch-explainer/multitouch_explainer.md)
[x] Gamepad Tests (https://github.com/bradleyneedham/gamepadtest)
[x] Tag Review (https://github.com/w3ctag/design-reviews/issues/799)

siusin commented 1 year ago

@bradleyneedham could you associate your GitHub account with your W3C account, please? It will help to resolve the IRP issue. Thank you.

bradleyneedham commented 1 year ago

Absolutely would if I had one :-). Does this work better if @sagoston submits the changes? Signed up for an account. No email to confirm yet. Will update here once resolved.

bradleyneedham commented 1 year ago

Ok, done, GitHub account should now be associated with my W3C account.

siusin commented 1 year ago

@bradleyneedham

Excellent, thank you! The editors are expected to review this pull request and merge it when ready.

marcoscaceres commented 1 year ago

@bradleyneedham, would you mind rebasing so it's easier to review?

bradleyneedham commented 1 year ago

Hi @marcoscaceres, took me a little but I think I got the rebase correct. This will hopefully be easier to see the changes.

bradleyneedham commented 1 year ago

@nondebug @sagoston @marcoscaceres Thank you all again for your review and comments. I rebased this, it still looks good to merge, the error that is now showing is in "index.html" not a file I changed. Let me know if there is something else I need to fix.

bradleyneedham commented 11 months ago

@marcoscaceres I have added links to the explainer, tests, and standards positions in the first comment. Thank you again for your time and consideration.

bradleyneedham commented 10 months ago

Hi @nondebug, the failure I am getting here is the same as the failure that https://github.com/w3c/gamepad/pull/172 is getting. It has to do with the reference to [="xr-standard" gamepad mapping=] on line 1023-1024 of index.html. The reference appears to be correct but the test does not appear to like it.

nondebug commented 10 months ago

Relevant error message:

Error: ROR] Couldn’t find “"xr-standard" gamepad mapping“ in this document or other cited documents: [dom], [hr-time], [html], [infra], [permissions-policy], [webidl], and [webxr-gamepads-module].

I'm not sure why that reference fails, it appears to be correct according to the xref tool:

https://respec.org/xref/?term=%22xr-standard%22+gamepad+mapping

@marcoscaceres can you take a look?