w3c / gamepad

Gamepad
https://w3c.github.io/gamepad/
Other
138 stars 49 forks source link

Drop SecureContext extended attrs from interfaces #194

Closed marcoscaceres closed 4 months ago

marcoscaceres commented 4 months ago

Closes #145

The following tasks have been completed:

Implementation commitment:


Preview | Diff

marcoscaceres commented 4 months ago

Send PR to WebKit to remove the warning.

msub2 commented 4 months ago

There is a separate WPT test for secure context also https://wpt.fyi/results/gamepad/gamepad-secure-context.html?label=experimental&label=master&aligned

marcoscaceres commented 4 months ago

@saschanaz can you let us know when gecko has been updated and a link to the relevant issue/patch on the gecko side?

saschanaz commented 4 months ago

Gecko has not been updated yet, I'll push the button ... ... 20 minutes ago: https://bugzilla.mozilla.org/show_bug.cgi?id=1870037

marcoscaceres commented 4 months ago

Thanks @saschanaz!

One last favor, can you review the updated tests (super small pr): https://github.com/web-platform-tests/wpt/pull/44691

marcoscaceres commented 4 months ago

@msub2 thanks for the reminder about the tests btw! Good catch! (and fixed!!!)

msub2 commented 4 months ago

No problem! I've been working on Servo's Gamepad implementation so it was pretty fresh in my mind

BlobTheKat commented 1 month ago

I've added a comment to the respective chromium bug to drop the restriction