Add extended buttons to support trackpad (#191)

w3c / gamepad

Gamepad

https://w3c.github.io/gamepad/

Other

141 stars 48 forks source link

Add extended buttons to support trackpad (#191) #196

Open xingri opened 6 months ago

xingri commented 6 months ago

Closes #191

The following tasks have been completed:

[ ] Modified Web platform tests (link to pull request)

Implementation commitment:

[ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=266293)
[X] Chromium (https://issues.chromium.org/issues/339841686)
[ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=)

Preview | Diff

xingri commented 5 months ago

Some suggested changes.

@marcoscaceres thank you so much for the detailed feedbacks. Will prepare the revised version based on your feedback soon.

xingri commented 4 months ago

Some suggested changes.

@marcoscaceres Thanks for the feedback. Applied most of the change requests.

Regarding the extended mapping, based on the working group discussion on last March with @nondebug while you were away, we discussed that we will not have the additional mapping type of "extended" for those gamepads that have a mapping that is "standard" plus extended bits. So, we'd keep "standard" but just have more controls.

Let's discuss a little bit during the call. Also I will fix the syntax error soon.

xingri commented 4 months ago

@marcoscaceres, @nondebug Please review the updated sentences. Also linked the webkit & chromium issues.

xingri commented 4 months ago

@marcoscaceres could you please review the changes and let me know if you need anything further.

xingri commented 2 months ago

@marcoscaceres , @nondebug As we discussed today, I have removed the table in the section 12.1. Please review this PR and let me know your feedback.