Add sequenceId slot and fix effect promises

w3c / gamepad

Gamepad

https://w3c.github.io/gamepad/

Other

142 stars 48 forks source link

Add sequenceId slot and fix effect promises #201

Open nondebug opened 6 months ago

nondebug commented 6 months ago

Closes #200

The following tasks have been completed:

[ ] Modified Web platform tests (link to pull request)

Implementation commitment:

[ ] WebKit
[ ] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=)
[ ] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=)

Preview | Diff

marcoscaceres commented 5 months ago

@gterzian, do you want to check this also?

marcoscaceres commented 5 months ago

Will need to check if the original issue is observable in any browser or if there was code already preventing this. Might be good if we can come up with a test to confirm (seems it might be possible to do so).

marcoscaceres commented 5 months ago

@nondebug I'm still not sure what happens if the identifiers don't match... feels like there should be some kind of assert or something somewhere to assuring nothing is getting out of sync.

nondebug commented 5 months ago

@gterzian Thanks for the suggestions!

@marcoscaceres Please take another look

marcoscaceres commented 3 months ago

Filed bug https://bugs.webkit.org/show_bug.cgi?id=277838