search

w3c / gamepad

Gamepad
https://w3c.github.io/gamepad/
Other
139 stars 49 forks source link

Add [Exposed] to all interfaces #63

Closed annevk closed 6 years ago

annevk commented 6 years ago

Needed for https://github.com/heycam/webidl/issues/365.

sgraham commented 6 years ago

I'm not familiar with this annotation, but I'm happy to merge any additions that fix some presentation issue.

annevk commented 6 years ago

It's not a presentation issue; it defines on which globals your interfaces are defined/exposed.

sagoston commented 6 years ago

We're not familiar with [Exposed] but I believe we only rely on Window (Window.navigator) in one place.

Could you create a PR for this issue?

sagoston commented 6 years ago

Added Exposed to all interfaces.

@annevk Can you please take a look and let us know if this is sufficient?

annevk commented 6 years ago

Yeah, thanks. I recommend including the issue in the commit message in the future, makes it easier to find the change.