search

w3c / geolocation

W3C Geolocation API
https://www.w3.org/TR/geolocation/
81 stars 56 forks source link

fix: callbacks are not EventHandlers #39

Closed marcoscaceres closed 4 years ago

marcoscaceres commented 4 years ago

Closes #24

The following tasks have been completed:

Implementation commitment:

Checked all three browsers, no one supports what was in the spec.

:boom: Error: 403 Forbidden :boom:

PR Preview failed to build. (Last tried on May 21, 2020, 6:32 AM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [HTML Diff Service](http://services.w3.org/htmldiff) - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request. :link: [Related URL](https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fpr-preview.s3.amazonaws.com%2Fw3c%2Fgeolocation-api%2Fpull%2F39%2F3341e1e.html&doc2=https%3A%2F%2Fpr-preview.s3.amazonaws.com%2Fw3c%2Fgeolocation-api%2Fpull%2F39.html) ``` HTML Diff service

W3C W3C Editors homepage

Create Diff between HTML pages

An error (403 Forbidden) occured trying to get https://pr-preview.s3.amazonaws.com/w3c/geolocation-api/pull/39/3341e1e.html.

Address of reference document:

Address of new document:

Tip: if the document uses the W3C convention on linking to its previous version, you can specify only the address of the new document — the previous link will be automatically detected.

Diff markings

This service relies on GNU diff. The found differences are roughly marked as follow:

  • deleted text is shown in pink with down-arrows (as styled for a <del> element)
  • where there is replacement, it’s shown in green with bi-directional arrows,
  • where there is newly inserted text, it’s yellow with up arrows (<ins> element)
script $Revision$ of $Date$
by Dominique Hazaël-Massieux
based on Shane McCarron’ Perl script wrapped in a Python CGI
``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/geolocation-api%2339.)._
marcoscaceres commented 4 years ago

@foolip, this should address #24 by just removing mention of handleEvent. Let me know what you think.

foolip commented 4 years ago

Thanks for the fix, @marcoscaceres!