w3c / hcls-fhir-rdf

Sketching out an RDF representation for FHIR
39 stars 15 forks source link

DBooth edits #109

Closed dbooth-boston closed 1 year ago

dbooth-boston commented 1 year ago

Eric and Gaurav, I've just pushed branch dbooth-edits to github. See the file v2.html there. There are several places I'd like input or discussion from you, which I've marked @@ like this @@.

dbooth-boston commented 1 year ago

@ericprud and Gaurav, I numbered the @@ TODO ... @@ items:

@@ TODO 1: Mark the FHIR Ontology draft on W3C github document as obsolete and point it to to generated FHIR RDF vocabulary/ontology @@

@@ TODO 2: Why is this background yellow and the others pink? @@

@@ TODO 3: What are these "working examples"? @@

@@ TODO 4: Which XSD prefix should we use? xs: or xsd: ? We should be consistent. The rest of the FHIR spec seems to use an xs: prefix. @@

@@ TODO 5: Should this use a bnode and fhir:v?
If not, how will readers know which FHIR properties have direct scalar values and which use a bnode with fhir:v? And how would it be extended? https://build.fhir.org/datatypes.html says "All data types (including primitives) may have extensions". @@

@@ TODO 6: Verify this example. fhir:Boolean? xsd:boolean? @@

@@ TODO 7: Fix this example @@

@@ TODO 8: Verify this example. @@

@@ TODO 9: Should we include the Concept IRI algorithm here? Or reference the google doc proposal? @@

ericprud commented 1 year ago

I was looking through the diffs but it seems they cover 97% of the document