w3c / hcls-fhir-rdf

Sketching out an RDF representation for FHIR
39 stars 15 forks source link

missing type assertion for [x] property #122

Open balhoff opened 1 year ago

balhoff commented 1 year ago

In https://build.fhir.org/list-example-double-cousin-relationship-pedigree.ttl.html there is a triple:

... fhir:deceased [ fhir:v "true"^^xsd:boolean ] ;

Here the boolean correctly has a datatype, but doesn't have a fhir:boolean even though this property is deceased[x].

dbooth-boston commented 11 months ago

Concluded on 8/10/23 that the spec is correct, except that we should add a type arc to the yellow schema. But the example generator needs to be fixed. https://www.w3.org/2023/08/10-hcls-irc#T15-56-16

tmprd commented 10 months ago

Not sure if this is well-known already ( related to #117 ), but almost all of the examples are missing this https://hl7.org/fhir/R5/examples-ttl.zip Looks like this prevents the ShEx validator from validating the rest https://github.com/fhircat/validation#manual-edits and also is detected by the HermiT reasoner. I'd like to learn about how all the RDF is generated, so I might be able to help with this one.

dbooth-boston commented 1 month ago

I just checked, and this is not fixed by https://github.com/HL7/kindling/pull/148

tmprd commented 1 month ago

I think this needs to be fixed here in the method ttlLiteral() in org.hl7.fhir.r5.elementmodel.TurtleParser, not the Kindling repo