Closed samuelweiler closed 4 years ago
I'm struggling with the line-by-line comments in the PR. Does it make sense to merge this PR as-is and then suggest changes - in new PRs - based on the new version?
I'm done commenting for the time being. So you could make changes and resubmit. I'll wait until you do that for further review.
@samuelweiler , if you update this PR, it will track each comment made by Richard...
@r12a I've made one change and suggested alternative text for one. I think we need solid clarifications from @plehegar for the rest. @plehegar, if we're still dickering over semantics, can we roll out this new doc anyway in the meantime, since it's so much more useful that what is there now?
@r12a ok to merge this for now and open separate issues to address the rest of your comments?
I'm going to merge this. Feel free to propose further changes to the doc and/or continue discussions re: what the semantics and behavior should be.
more "how" than "why"