search

w3c / hr-time

High Resolution Time
https://w3c.github.io/hr-time/
Other
52 stars 30 forks source link

Expose everywhere #130

Closed Ms2ger closed 2 years ago

Ms2ger commented 2 years ago

Ref: https://github.com/tc39/proposal-shadowrealm/issues/331

Implementation commitment - primarily for "change" and other normative changes: Positive initial signals from Google, Apple, Mozilla on the general direction.

Tasks:

Preview | Diff

w3cbot commented 2 years ago

yoavweiss marked as non substantive for IPR from ash-nazg.

yoavweiss commented 2 years ago

I'd want to understand the implementation commitments before landing though...

w3cbot commented 2 years ago

Ms2ger marked as substantive for IPR from ash-nazg.

marcoscaceres commented 2 years ago

Note, I don't think WebIDL2.js supports this yet? cc @saschanaz

saschanaz commented 2 years ago

The corresponding spec PR is not landed: https://github.com/whatwg/webidl/pull/526

I can prepare a draft PR early, though.

marcoscaceres commented 2 years ago

The next release of ReSpec will include support for this (via WebIDL2.js)... should be landing in the next 24 hours.

saschanaz commented 2 years ago

Somehow spec-prod still gets the previous version of webidl2.js and I wonder it implicitly uses a cache for yarn add? @sidvishnoi

sidvishnoi commented 2 years ago

@saschanaz

Somehow spec-prod still gets the previous version of webidl2.js and I wonder it implicitly uses a cache for yarn add?

spec-prod doesn't cache dependencies (not webidl2.js at least). Can you share where you found it being cached?

Current build error seems to be a regression in ReSpec (marked is not a function). Will send a fix and release soon.

saschanaz commented 2 years ago

Tried on my fork: https://github.com/saschanaz/hr-time/runs/4119110069?check_suite_focus=true

I don't see marked issue there, but only the validation failure.

Edit: BTW, probably useful if it shows which version of the library is installed.

sidvishnoi commented 2 years ago

webidl2 error occurred as an older version got installed in a previous step with yarn add reffy. yarn add webidl2 just decided to use the one available instead of latest as an optimization (yarn's optimization as we didn't ask for specific version). Will use webidl2@latest instead.

BTW, probably useful if it shows which version of the library is installed.

Good point, will add. spec-prod does show for respec/bikeshed, but not for other libraries.

Update: Fixed in spec-prod v2 ≡ v2.6.4.

saschanaz commented 2 years ago

Now yarn argues that it gets webidl2@24.2.0 but still fails to parse the IDL. Not sure what's happening, since ReSpec itself can now parse it properly with that version.

sidvishnoi commented 2 years ago

@saschanaz Should be ok now with v2.6.5

saschanaz commented 2 years ago

Thanks! Things are definitely not simple 😭

saschanaz commented 2 years ago

Since it now runs well in my fork, probably someone with proper access should rerun the job and then everything should be okay.

marcoscaceres commented 2 years ago

Re-running…

Ms2ger commented 2 years ago

This should be ready to merge now; I'll submit tests to WPT once the IDL changes have propagated from webref.

Ms2ger commented 2 years ago

Hey @yoavweiss, is there anything I need to do on my side to move this along?

marcoscaceres commented 2 years ago

Merging as it was approved! Thanks for the poke @Ms2ger!