search

w3c / html-aria

ARIA in HTML
https://w3c.github.io/html-aria/
Other
181 stars 48 forks source link

Fixes #117 #118

Closed carmacleod closed 4 years ago

carmacleod commented 5 years ago

Fixes #117

Preview | Diff

marcoscaceres commented 5 years ago

Is this stale @stevefaulkner? If still good, @carmacleod, could you fix the merge conflict?

stevefaulkner commented 5 years ago

thanks for PR @carmacleod "This branch has conflicts that must be resolved"

carmacleod commented 5 years ago

@marcoscaceres Branch is refreshed; conflicts resolved.

@stevefaulkner Just so you know, I made 2 additional (but tiny) changes:

  1. Since nav had the (changed) keyword, I figure role=navigation needed it too - correct?
  2. I added the word "then" because with all those words crammed into a table cell, it was confusing to read, and "then" adds clarity.
marcoscaceres commented 5 years ago

Marked as non substantive for IPR from ash-nazg.

marcoscaceres commented 5 years ago

Thanks @carmacleod for the update 🧁. Over to @stevefaulkner for final review and to answer your questions.

scottaohara commented 4 years ago

@stevefaulkner, @carmacleod

Looking over this, it is an improvement to clarify the information and I'm going to merge it in, but noting there's additional work to do / consider in #63.