search

w3c / html-aria

ARIA in HTML
https://w3c.github.io/html-aria/
Other
181 stars 48 forks source link

Style changes on table: Rules of ARIA attributes usage by HTML language feature #141

Closed pgrucza closed 5 years ago

pgrucza commented 5 years ago

With recent updates to the Editor's Draft there seems to be some styling changes to the table for Rules of ARIA attributes usage by HTML language feature. The currently published Working Draft has grey table headings and is striped white and grey. Columns are also separated. The Editor's Draft uses dark blue headings and is striped blue and grey. Columns are not visually separated. A class="simple" has been applied to the table.

I'm wondering if this styling change is intentional or is it a side effect of the recent updates?

marcoscaceres commented 5 years ago

My bad. The change was... um... half intentional. We should probably remove any custom style from the spec and let basic.css handle the table styling.

marcoscaceres commented 5 years ago

@pgrucza you want to take this one too? At least, have a play with removing the custom style in the spec and seeing if simple is enough.

pgrucza commented 5 years ago

I'll have a look ( likely tomorrow ). Is there anything I need to be aware of in your previous changes for the layout ?

marcoscaceres commented 5 years ago

No, nothing that I can think of.

pgrucza commented 5 years ago

133 added class="simple"

removing the class="simple" allows basic.css to do its work again

marcoscaceres commented 5 years ago

removing the class="simple" allows basic.css to do its work again

Sorry, I think I might have confused you... ".simple" is part of basic.css. However, the document is adding "makeup.css", which includes some style rules for table. Those are the ones that need that need to be removed, I think... namely:

tr:nth-child(2n+1) {
  background-color: #ebebeb;
}

Which is conflicting with "simple".

pgrucza commented 5 years ago

ok returned class="simple" to the tables removed:

tr:nth-child(2n+1) {
  background-color: #ebebeb;
}

from makeup.css

This leaves the blue header row and light blue striping coming from simple. Inline ReSpec 3 CSS

For request, "fixing links in ahref and anohref" #143