w3c / html-aria

ARIA in HTML
https://w3c.github.io/html-aria/
Other
181 stars 48 forks source link

Tidy up id and tabindex in docconformance table rows #181

Closed carmacleod closed 4 years ago

carmacleod commented 4 years ago

In hopeful preparation for linking into the ARIA in HTML spec from the HTML element specs, need to ensure that row id's in the docconformance table are all present and robustly named, and that tabindex="-1" is consistently added to each row.

For example:

Not sure what to do about:

I will provide an initial PR for this shortly.

scottaohara commented 4 years ago

Thanks @carmacleod.

carmacleod commented 4 years ago

Any opinions on the items in the "Not sure" list above? I could go either way on those.

scottaohara commented 4 years ago

per talking to @carmacleod some more about this offline, reopening for further updates.

carmacleod commented 4 years ago

Decision was to go with:

Note that this naming scheme makes id's consistent with the HTML-AAM spec.

Also decided that only one id is needed for each element/type/attribute because planned consolidation will place related entries next to one another.

ZoeBijl commented 4 years ago

Also decided that only one id is needed for each element/type/attribute because planned consolidation will place related entries next to one another.

Oef, that sounds dangerous to me. As it stands it’s super easy to link to a specific part. I would regret it if that wasn’t possible anymore in the future.

scottaohara commented 4 years ago

i don't think it will be an issue. also, as work is still going on here, better to plan for what we know is going to be available, vs a bunch of ids that will need changing.

carmacleod commented 4 years ago

Tidying up even more, with a new PR: https://github.com/w3c/html-aria/pull/183

@ZoeBijl For now, the specific direct links are still there. The first link to an element entry uses el-xx, and if there are other entries, they look like el-xx-whatever, and they link to the entry immediately following el-xx.

The only inconsistent one is el-input-text-list, which is being used for

input type= text, search, tel, url, or email with a list attribute

... but that one was inconsistent before, so I don't feel too bad about leaving it like that for now. ;)

I'm sure @scottaohara will figure out a nice way to consolidate those... :) perhaps by creating new el-input-xx-list entries that immediately follow el-input-text, el-input-search, el-input-tel, el-input-url, and el-input-email.