search

w3c / html-aria

ARIA in HTML
https://w3c.github.io/html-aria/
Other
181 stars 49 forks source link

Add entry for form-associated custom element #204

Closed carmacleod closed 4 years ago

carmacleod commented 4 years ago

Closes #203

Preview | Diff

carmacleod commented 4 years ago

I think maybe respec doesn't like the dash in <a>form-associated custom elements</a>? https://respec.org/xref/?term=form-associated+custom+element&specs=html&types=_CONCEPT_

But even if I replace the - with a space, there still seems to be a _CONCEPT_ error? https://respec.org/xref/?term=form+associated+custom+element&specs=html&types=_CONCEPT_

The concept link in the html spec is: https://html.spec.whatwg.org/multipage/custom-elements.html#form-associated-custom-element and its definition (in the DOM) looks like this:

<dfn id="form-associated-custom-element">form-associated custom element</dfn>

@marcoscaceres Is there some kind of data-lt magic I need to do over on the html side to get this html-aria pr to build? Or can it be fixed in this pr somehow? Sorry - I'm very new to respec. :)

carmacleod commented 4 years ago

So, I think I've figured it out (the presence or absence of the dash was a red herring). I think the definition of "form-associated custom element" in the html spec source needs data-export:

<dfn data-export="">form-associated custom element</dfn>

Pretty sure that is what is making "autonomous custom element" link up correctly. That source is:

<dfn data-export="">autonomous custom element</dfn>

Is there a way to test this without first merging the data-export code into the html spec?

carmacleod commented 4 years ago

This should build ok now, I hope, because this pr has been merged: https://github.com/whatwg/html/pull/5153

scottaohara commented 4 years ago

Marked as non substantive for IPR from ash-nazg.

carmacleod commented 4 years ago

@marcoscaceres I tried to fix this "missing dfn" respec error, but the build is still failing, so I'm stuck now and need help please.

carmacleod commented 4 years ago

@marcoscaceres ReSpec is happy now, and the build is working! Apparently the database that ReSpec uses to look up the definitions can take a while to update. I rebuilt just now (17 hours later), and the dfn is no longer missing. Thanks to @annevk for the suggestion!

@scottaohara @stevefaulkner This PR is now ready for review.

carmacleod commented 4 years ago

I think we need radiogroup also?

scottaohara commented 4 years ago

I think we need radiogroup also?

yes, agreed.

marcoscaceres commented 4 years ago

Yes, sometimes it can take 24 hours to get an update... usually it happens pretty quick :)