Closed scottaohara closed 3 years ago
edit: scratching the note I had here. needs to be thought out more and i want to run some tests.
Would still be good to make the change to the other tables to start rows with a
<th>
rather than just having that for the one new table?
happy to try and make a semi-clever find/replace for this if you want, @scottaohara
@patrickhlauke i wouldn't mind but for the fact I have other PRs that may have unnecessary merge conflicts if we go doing that here. I'd rather just get this and the other PRs merged in, and then this can easily be done.
@patrickhlauke i wouldn't mind but for the fact I have other PRs that may have unnecessary merge conflicts if we go doing that here. I'd rather just get this and the other PRs merged in, and then this can easily be done.
ok makes sense. i opened a separate issue to track this. so with that out of the way, i think this is good to go
Treat these tables separately so we can be more clear with guidance specific to roles vs attributes.
adds in new specific attribute call outs on elements such as checkbox, radio, options and selects which should not have specific aria-* attributes set.
revised/re-explained allowances for specific html attributes and their implicit aria attribute semantics are in the new second table.
This PR will close #122, #225 and #241
Preview | Diff