search

w3c / html-aria

ARIA in HTML
https://w3c.github.io/html-aria/
Other
181 stars 49 forks source link

Correction: revise allowed roles for iframe, object, embed #370

Closed scottaohara closed 2 years ago

scottaohara commented 2 years ago

closes #368

Removes role allowances for iframe, object and embed per reasoning provided in the linked issue.

Need at least two checkers to accept this change before we can merge.

Preview | Diff

Preview | Diff

scottaohara commented 2 years ago

@WilcoFiers, just wanted to respond to let you know I am not ignoring your responses. Just been very busy as of late, but i have been slowly writing test result data for these elements. quick preview is that there are definitely some cases where specifying roles may be helpful (particularly img on objects that render images), but document/application roles either aren't useful, or they can actually make the content inaccessible in some cases.

Will report more as soon as i can.

WilcoFiers commented 2 years ago

@scottaohara Sure thing. I'm not familiar enough with how application / document interact with iframe / object to say either way. It's the other cases that concern me. Would be interested to know though if there's anything interesting you can do with those, or what problems might occur with them.

jcsteh commented 2 years ago

To be clear, I'm not necessarily saying role="none" on iframes is a bad idea. What I am saying is that the support across implementations is currently inconsistent and fixing that is non-trivial. Given that this spec primarily exists for conformance checkers, it seems important that it reflects the reality of what is actually supported. Otherwise, authors will believe they are compliant but it won't actually work across browsers in reality.

role="img" is less clear to me even from a theoretical perspective. As I noted in #368, role="img" is supposed to make children presentational. I don't see how browsers can technically support that for iframe documents given site isolation, etc.

scottaohara commented 2 years ago

As I just have not had the time to finalize all the necessary work to complete and revise this PR, I'm closing this down and will instead create new PRs and necessary issues for the different elements that were to be covered by this change.