w3c / html-aria

ARIA in HTML
https://w3c.github.io/html-aria/
Other
178 stars 48 forks source link

Addition: expand role allowances for fieldset element #442

Open scottaohara opened 1 year ago

scottaohara commented 1 year ago

closes #400

Updates allowances for the toolbar, menubar, menu, listbox, tablist, article, dialog and region roles to be used on the fieldset element.


Preview | Diff

smhigley commented 1 year ago

I like the role expansion. I think some of these other roles might also merit being allowed on fieldset:

stevefaulkner commented 1 year ago

@scottaohara @smhigley Am not understanding the use cases for making control grouping/labelling semantic elements into non control grouping.

scottaohara commented 1 year ago

@stevefaulkner happy to talk about this when i get back to work in the new year. but quickly, the intent here is to stop disallowing the use of roles on elements where it's actually preventing the ability for some developers to rectify poor markup.

An alternate proposal i have also been working on is to more clearly indicate what roles MUST NOT be used by developers, vs those which belong more in the SHOULD NOT category (e.g., use the appropriate HTML element instead). article, and maybe some of the roles that Sarah mentioned, could very well belong to the 'should not' category... more on that when we speak though.

stevefaulkner commented 1 year ago

Yeah no worries let’s discuss when you are back!

On Wednesday, 28 December 2022, scottaohara @.***> wrote:

@stevefaulkner https://github.com/stevefaulkner happy to talk about this when i get back to work in the new year. but quickly, the intent here is to stop disallowing the use of roles on elements where it's actually preventing the ability for some developers to rectify poor markup.

An alternate proposal i have also been working on is to more clearly indicate what roles MUST NOT be used by developers, vs those which belong more in the SHOULD NOT category (e.g., use the appropriate HTML element instead). article, and maybe some of the roles that Sarah mentioned, could very well belong to the 'should not' category... more on that when we speak though.

— Reply to this email directly, view it on GitHub https://github.com/w3c/html-aria/pull/442#issuecomment-1366793683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMCE3LKX623LM6STN5YNTWPRWYDANCNFSM6AAAAAATF3OCDM . You are receiving this because you were mentioned.Message ID: @.***>

--

Regards

Steve Faulkner Web Standards messaging one t-shirt at a time https://www.etsy.com/uk/shop/HTMLZ

scottaohara commented 1 year ago

noting that steve and i talked this over. going to move forward with the further clarification proposal i had mentioned in my last comment, so this PR will be adjusted.