search

w3c / i18n-checker

W3C's i18n checker
https://validator.w3.org/i18n-checker/
Other
36 stars 17 forks source link

Not working with http:// trying to force https:// #79

Closed kilroy59 closed 5 years ago

kilroy59 commented 5 years ago

Can't find site which is up. Fairly sure it's forcing https:// which doesn't exist for site I'm testing.

r12a commented 5 years ago

@kilroy59 Thanks for the report. I'll pass it on to the systems team, however, it would help a lot if you could indicate which page you were trying to test.

kilroy59 commented 5 years ago

r12a I tried two different sites. First the one I wanted to test. http://www.imawww.com/ and then to verify it was the checker and not the site, http://www.turvill.com/ In both cases it returns the site with a https prefix and an unreachable message. All the https sites I tested worked fine.

gosko commented 5 years ago

I committed a fix but it is not yet deployed on our site. Hopefully will be deployed by tomorrow.

r12a commented 5 years ago

@gosko what's the status on this? The checker still doesn't find http://www.imawww.com/

gosko commented 5 years ago

@r12a @kilroy59 I believe this should now be deployed on our servers, could you please confirm it is working as expected?

r12a commented 5 years ago

@gosko Doesn't appear to be. I go to https://validator.w3.org/i18n-checker/ add www.imawww.com to the input field, and get the same problem. And the text in the input field is changed to https://www.imawww.com/ (and yes, i did a shift-reload of the page first).

gosko commented 5 years ago

@r12a The bug was that the checker was stripping the protocol from submitted URIs and forcing https no matter what was submitted, i.e. URIs starting with http://www.example.org were rewritten to www.example.org. That has been fixed.

If you omit the protocol, the checker defaults to https which seems reasonable to me.

kilroy59 commented 5 years ago

Just checked and http://www.imawww.com/ still changes to https://www.imawww.com/ and is unreachable.

gosko commented 5 years ago

@kilroy59 Yes, confirmed, sorry. Maybe one of our two backend servers is still out of date. I will investigate further.

gosko commented 5 years ago

@kilroy59 @r12a I think this should finally be fixed for real. One of the resources was being served from a cache. I don't understand how it worked for me when I was testing yesterday – maybe my browser had a cached version from when I was debugging last month.

kilroy59 commented 5 years ago

Yes, finally! Thank you for your hard work. Now, time for me to add a language attribute to the html tag :)

xfq commented 5 years ago

Confirmed. Closing.