w3c / i18n-drafts

A place to edit articles, tutorials, and the like for the /International subtree of the W3C site. Also, captures issues and comments.
63 stars 61 forks source link

Language tags French t9n update #557

Closed clavoline closed 11 months ago

clavoline commented 11 months ago

@r12a Submitting the changes again because I think I got it wrong the first time, sorry!

netlify[bot] commented 11 months ago

Deploy Preview for i18n-drafts ready!

Name Link
Latest commit 2006baf150b946000e355a985d513a1258a1ac5e
Latest deploy log https://app.netlify.com/sites/i18n-drafts/deploys/654385479ca1b40008dd6159
Deploy Preview https://deploy-preview-557--i18n-drafts.netlify.app/articles/language-tags/index.fr
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

r12a commented 11 months ago

hi @clavoline it took me a while to finish reviewing this because there are many differences in the way you arranged the text, but i think it looks ok, with one small exception (compared with the proposed new english version).

The note just below the top heading doesn't follow our current style. You need to change the class from note to info.

Otherwise, i think we're good. Thanks.

clavoline commented 11 months ago

@r12a Thank you. Sorry I missed that one!

r12a commented 11 months ago

Ah, that didn't quite work. I think we need to replace the div with a p.

r12a commented 11 months ago

Looks good. Happy for me to publish and announce it ?

clavoline commented 11 months ago

@r12a Of course, if you're happy with it!

r12a commented 11 months ago

For the record, i had to fix a number of validation errors, and put section tags around all the new section headings (with ids). The diff can be seen at https://github.com/w3c/i18n-drafts/commit/b026502df67a39600a6a0498adcbc2d4e6339243

clavoline commented 11 months ago

@r12a My apologies - I forgot about the translation checklist and didn't realize sections were also required for H3s.

r12a commented 11 months ago

np @clavoline I just pointed to it so that you are aware for next time :-)

All announced now. https://w3c.social/@webi18n/111341218907831498 https://twitter.com/webi18n/status/1720072602751029600

r12a commented 11 months ago

@clavoline we have some feedback on mastodon, suggesting that étiquettes should be balises. Do you think we should change it? https://w3c.social/@webi18n/111341218907831498

r12a commented 11 months ago

I think balise refers to markup tags, rather than language tags??

clavoline commented 11 months ago

I think balise refers to markup tags, rather than language tags??

Agreed. This is one of the first questions I asked myself!

These 3 sources use "étiquettes":