search

w3c / imsc-tests

IMSC test suites
https://w3c.github.io/imsc-tests/
Other
16 stars 13 forks source link

add linepadding tests #104

Closed btsimonh closed 1 year ago

btsimonh commented 2 years ago

linepadding001: simplest case, 2 spans with BR between linepadding002: first line ends with ruby. Illustrates render issue resolved in https://github.com/sandflow/imscJS/pull/234 linepadding003: nested spans, ruby spans with no ruby text, ruby wrapped onto next line. linepadding004: Simple wrapped span.

palemieux commented 2 years ago

: first line ends with ruby. Illustrates render issue resolved in https://github.com/sandflow/imscJS/pull/234

@btsimonh In linepadding002.ttml, backgroundColor is specified on the ruby container instead of the ruby base, so I am not convinced that we should see any line padding effect.

btsimonh commented 2 years ago

Will review. Boxing of ruby in browsers is very hit and miss; I could not find a way to effectively box the actual ruby text with a transparent box, as the browser always managed to make an undesirable presentation; so my current advice ref boxing a ruby is "don't unless you know how it will come out". Shall I add a couple of vertical linepadding tests? br, s

btsimonh commented 2 years ago

@btsimonh In linepadding002.ttml, backgroundColor is specified on the ruby container instead of the ruby base, so I am not convinced that we should see any line padding effect.

hmmm.. for me it's the ruby container which is part of the line, not the ruby base. What is wholly not clear is if a background color on the ruby container should box including the ruby or not (i.e. be taller). at the moment not.

I guess let's not consider merging until the corresponding issue/PR in the imscJS repo is understood more fully?