search

w3c / imsc-tests

IMSC test suites
https://w3c.github.io/imsc-tests/
Other
16 stars 13 forks source link

Add tt:image test #62

Closed palemieux closed 6 years ago

palemieux commented 6 years ago

@nigelmegitt I have fixed the aspect ratio.

palemieux commented 6 years ago

@nigelmegitt Ping

nigelmegitt commented 6 years ago

@palemieux sorry, thanks for waking me up on this one. I just re-reviewed and I think there's still something unexpected here.

tts:extent="640px 480px" andttp:displayAspectRatio="4 3"` but the output images are still 16:9, specifically 640x360px. I'm expecting 640x480px images for this test case.

I can see that the placed image is no longer squeezed, but the apparent location is wrong. It should have a top left at 128px 128px but by my rough measurements its top left is actually 176px 96px. Also its extent is supposed to be 160px 120px but I measure it as 120px 90px - the same aspect ratio but shrunk. The source image measures correctly as 160px 120px.

It seems as though two unexpected things have happened:

  1. The reference output image is the wrong aspect ratio
  2. The reference output image has been shrunk

I'm not expecting this test case to demonstrate positioning of a 4:3 root container region within a 16:9 context but that is what it appears to do. Unfortunately the reference image does not show any kind of boundary between the root container region and the outer context so that doesn't look very clear.

Your thoughts @palemieux?

palemieux commented 6 years ago

@nigelmegitt See improved test

palemieux commented 6 years ago

@nigelmegitt All tests are rendered to same resolution as described at https://github.com/w3c/imsc-tests/blob/master/imsc1/README.md