w3c / jlreq

Text Layout Requirements for Japanese
https://w3c.github.io/jlreq/
Other
101 stars 17 forks source link

anchors appear to have been broken in some update #251

Open frivoal opened 3 years ago

frivoal commented 3 years ago

Anchors that used to work on historic version so of JLREQ no longer do (e.g. https://www.w3.org/TR/2012/NOTE-jlreq-20120403/#fig2_3_29_2-en works but https://www.w3.org/TR/jlreq/#fig2_3_29_2-en doesn't).

That's very annoying, as there are all sorts of placing linking to various parts of JLREQ, and finding what the link is supposed to be talking about when you only get taken to the top of the document isn't easy (except by ignoring the latest version and going back to the previous one).

Could these old anchors be restored?

himorin commented 3 years ago

thank you for pointing this. I've not noticed on this. When we've unite two languages into one page, id(s) at divs which wrap img were converted to id(s) at figures which wrap two images (of en/ja), and renamed as e.g. fig2_3_29_2-en/fig2_3_29_2-ja to fig2_3_29.

@kidayasuo @r12a If you feel fine, I'd open PR to add ids of -en/-ja to img within figure like below. How do you think?

<figure id="figA">
  <img its-locale-filter-list="en" id="figA-en" ...>
  <img its-locale-filter-list="ja" id="figA-ja" ...>
  <span ....