w3c / jlreq

Text Layout Requirements for Japanese
https://w3c.github.io/jlreq/
Other
101 stars 17 forks source link

port scripts into respec post-script by promise #264

Closed himorin closed 7 months ago

himorin commented 3 years ago

as proposal, closes #260

further items which could be investigated


:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on Apr 27, 2021, 5:49 AM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [Spec Generator](https://www.w3.org/2015/labs/) - Spec Generator is the web service used to build specs that rely on ReSpec. :link: [Related URL](https://labs.w3.org/spec-generator/?type=respec&url=https%3A%2F%2Frawcdn.githack.com%2Fhimorin%2Fjlreq%2F64655bd7e1eb876fd6acd8374eda9b21bb92164c%2Findex.html%3FisPreview%3Dtrue) ``` Navigation timeout of 29615 ms exceeded ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/jlreq%23264.)._

:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on Mar 4, 2024, 5:36 AM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [Spec Generator](https://www.w3.org/2015/labs/) - Spec Generator is the web service used to build specs that rely on ReSpec. :link: [Related URL]([object Object]) ``` Navigation timeout of 28237 ms exceeded ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/jlreq%23264.)._
kidayasuo commented 2 years ago

@r12a and this one, please. Thank you!

kidayasuo commented 7 months ago

From JLReq TF meeting on 2024-2-27: We would like to include this fix to the next and possibly the final revision of JLReq. The fix was developed three years ago, reviewed and approved by one reviewer (@xfq).

@r12a, I would greatly appreciate it if you could add your review. If we do not hear from you in two weeks we would like to go ahead with merging. thanks!

xfq commented 7 months ago

(Note that this branch has conflicts that must be resolved.)

r12a commented 7 months ago

Sorry, i thought i'd already replied on this. It's been a long time since i wrote the code which is being changed here, and (1) it will take me a long time to review properly, (2) i am not familiar with how to use promises in JS.

Could someone indicate why the change is being made, and how it affects current functionality for the user?

Btw, i thought that the Japanese translations for the SOTD were provided by respec - we worked with them on localisation code. Could someone check the situation? (maybe @xfq).

xfq commented 7 months ago

Sorry, i thought i'd already replied on this. It's been a long time since i wrote the code which is being changed here, and (1) it will take me a long time to review properly, (2) i am not familiar with how to use promises in JS.

Could someone indicate why the change is being made, and how it affects current functionality for the user?

The change is being made because the current language switching function doesn't work. See https://github.com/w3c/jlreq/issues/260

Btw, i thought that the Japanese translations for the SOTD were provided by respec - we worked with them on localisation code. Could someone check the situation? (maybe @xfq).

Their translation does not include SOTD, and their localisation code is not suitable for us IIRC. It is only suitable when the full document is in Japanese (static lang=ja, not dynamic switching).