search

w3c / jlreq

Text Layout Requirements for Japanese
https://w3c.github.io/jlreq/
Other
100 stars 16 forks source link

updated per issue #287 #288

Closed himorin closed 1 year ago

himorin commented 3 years ago

closes #287.

@kidayasuo how about adding any other possible templates? (e.g. 編集会議issues with mention to a collecting issue and a text mentioning issue is for 編集会議 - should be indicated by label??)

kidayasuo commented 3 years ago

If new templates reduce your maintenance work please go ahead.

kidayasuo commented 2 years ago

編集会議ネタ might not be relevant any more as the one Kobayashi-san is editing is the last article of the serial articles. Other changes look fine.

himorin commented 2 years ago

removed one as suggested by @kidayasuo

xfq commented 2 years ago

FYI - GitHub now supports a new template format. Maybe we can try it in the future. See some examples below:

himorin commented 1 year ago

FYI - GitHub now supports a new template format. Maybe we can try it in the future. See some examples below:

Yeah,, I've noticed, but it seems for me no further advanced feature is not required for our current usage to create new issue, at this moment...

r12a commented 1 year ago

I spent a while trying it out, but couldn't figure out how to make it work. I could be useful for the i18n-request issue templates.

himorin commented 1 year ago

I spent a while trying it out, but couldn't figure out how to make it work. I could be useful for the i18n-request issue templates.

I'm not sure what was the target to be achieved, but something like this test case?

r12a commented 1 year ago

Thanks. That's interesting. Some things i noticed:

  1. it would be better if the initial text inside the input elements was a placeholder, rather than a value. Is that possible?
  2. Users don't seem to be able to type free form text into the comment - presumably one needs to provide a textarea for 'other comments'.
  3. i assume that we can add regular text around the form fields? (eg. for instructions)

I can't see the source code that lies behind all this, because it's in your fork. Could you explain how you did it? Thanks.

himorin commented 1 year ago

Thanks. That's interesting. Some things i noticed:

1. it would be better if the initial text inside the input elements was a placeholder, rather than a value. Is that possible?

updated.

2. Users don't seem to be able to type free form text into the comment - presumably one needs to provide a textarea for 'other comments'.

I really forgot about that. added.

3. i assume that we can add regular text around the form fields? (eg. for instructions)

yes. see updated one. (like name of specification part)

I can't see the source code that lies behind all this, because it's in your fork. Could you explain how you did it? Thanks.

please check following file for template under testing https://github.com/himorin/i18n-request/blob/gh-pages/.github/ISSUE_TEMPLATE/test-request-a-check-of-a-self-review.yml

r12a commented 1 year ago

@himorin many thanks indeed for showing me how to do this! I have now converted all of our i18n-request new issues to use the YAML form approach. See https://github.com/w3c/i18n-request/issues/new/choose

himorin commented 1 year ago

@r12a Thank you for letting me know (of course I've noticed about PR, though), and congrats for success!

But, I'd go with current style for jlreq as in this PR:

So, I'd request re-review on this PR from you (@r12a ) and @kidayasuo with the current PR.

r12a commented 1 year ago

@himorin i agree that you don't need to use the form-based approach for the templates you are editing. It seem this PR is just about translation, for which you are the expert, so i'm ok with the PR.

himorin commented 1 year ago

got +1 from @kidayasuo also (via direct conversation), merging this.