Tests for #99: Framing matches on specified value

michaelcpuckett commented 4 years ago

I noticed a discrepancy between JSON-LD Playground and RDF Distiller regarding frame matching.

This PR adds 3 tests for frame matching on a specified value.

Original issue here:

I created a fix for this in jsonld.js repo and the I'm hoping to commit the tests here.

michaelcpuckett commented 4 years ago

One check has failed. I joined the JSON-LD group a few days ago but it's reporting that I haven't, I think. https://www.w3.org/users/121373

iherman commented 4 years ago

Admin note: even in case of acceptance, this PR does not produce substantive (ie, IPR related) changes in the spec, so I set the checks accordingly.

iherman commented 4 years ago

Marked as non substantive for IPR from ash-nazg.

iherman commented 4 years ago

One check has failed. I joined the JSON-LD group a few days ago but it's reporting that I haven't, I think. https://www.w3.org/users/121373

Unfortunately, this is more complicated...

first of all, for our checks to combine the github event with W3C specific issues you have to manually 'connect' your W3C account with the github id. This can be done if you go to your W3C profile page above, and check the appropriate menu item on the left hand bar.
however, to be a bona fide JSON WG member, your institution must be a W3C member, and this institution would then 'delegate' you to the Working Group. And, I'm afraid, your employer is not a W3C member...

Anyway, your contribution is not affecting IPR (the main reason of all this check on the PR), and I so noted. So your PR is o.k.

gkellogg commented 4 years ago

Tests look good, thanks!

gkellogg commented 4 years ago

Fixes #99.

w3c / json-ld-framing