Closed gkellogg closed 5 years ago
LGTM! :)
(Sorry, misclick)
Can we simplify the example to contain only what is really necessary to understand the feature? From the point of view of this feature aliasing @type
, @id
, or indeed @included
, but also the usage of @base
seems to be totally irrelevant. The same for the usage of type for the included objects.
This would help the user concentrating on what is really essential in this case...
(Otherwise it looks o.k. to me...)
The example came from Rob’s original use case, but I can simplify it easily enough.
Actually... the comment of @dlongley in https://github.com/w3c/json-ld-syntax/issues/128#issuecomment-516936845 made me realize that, at least for me, the most important aspect of this feature is not what is in the proposed text. Indeed, what @included
can replace is the misleading top level @graph
when what one wants to expess is a “bush”, ie, several top level objects with their (recursive) properties. This is used all over the place in Turtle data, and for which the only solution in JSON-LD 1.0 is to use a top-level @graph
property whoise value is... not a graph in the dataset sense (certainly not the same way as when a TriG data is encoded in JSON-LD).
If my understanding is indeed correct, I would think that such an example should be “the” core example for this feature, and the cross references in @azaroth42’s example is just a welcome consequence...
Or, at least, this fact should be emphasized in the text imho.
@iherman Please suggest some text and an example to help flesh this out in the spec. I'll be happy to integrate it into the text.
@iherman,
Indeed, what @included can replace is the misleading top level @graph when what one wants to expess is a “bush”, ie, several top level objects with their (recursive) properties.
Yes, this is also my understanding -- I left a comment to similar effect over on the API PR:
https://github.com/w3c/json-ld-api/pull/128#pullrequestreview-269051034
@gkellogg
@iherman Please suggest some text and an example to help flesh this out in the spec. I'll be happy to integrate it into the text.
Hopefully, the PR over this PR works: https://github.com/w3c/json-ld-syntax/pull/209
This issue was discussed in a meeting.
RESOLVED: focus <code>@included</code> text and example on original inclusion use case; mention value of it as an <code>@graph</code> replacement for bushes–and reference primer for further reading
RESOLVED: close issue #19 with merger of <code>@included</code> related PRs
@included
@included
now.16:13:56 <bigbluehat> https://jsonapi.org/@included
comes from the JSON.API spec, and we are adopting this.@included
can be used in favor of @graph
in these places.@included
you can.@graph
to define a default graph.@included
is out of sync with other keywords.@include
@graph
is misleading, as it has not been explained yet there.@graph
section then.@graph,
so readers will have to know what it does.@graph
at the top level if not needed.@graph
to @included?
@included
were @graph,
this would make a named graph?@id
or @vocab
you can define that thing.@included.
@included
text and example on original inclusion use case; mention value of it as an @graph
replacement for bushes–and reference primer for further reading (Benjamin Young)@included
text and example on original inclusion use case; mention value of it as an @graph
replacement for bushes–and reference primer for further reading@included
@included
related PRs (Benjamin Young)@included
related PRs
For #19.
Preview | Diff