Updates to accommodate ReSpec changes and subsequent issues found post-REC.

w3c / json-ld-syntax

JSON-LD 1.1 Specification

https://w3c.github.io/json-ld-syntax/

Other

111 stars 22 forks source link

Updates to accommodate ReSpec changes and subsequent issues found post-REC. #365

Closed gkellogg closed 3 years ago

gkellogg commented 3 years ago

Use respec-w3c instead of respec-w3c-comman.
Update playground links to not be flagged by ReSpec.
Update ReSpec configuration to use group: "wg/json-ld" instead of separate wg* attributes.
Remove old dependence on ReSpec definition list and non-existant "end" subscription.
Miscellaneous spelling and grammar fixes suggested by @shujikamitsuna.

Fixes #364.

Preview | Diff

gkellogg commented 3 years ago

The update to ReSpec caused a bunch of changes, and we lost the (probably already broken) ability to filter out unused definitions, but we should be less subject to changes to ReSpec internals, going forward.

See also w3c/respec#2767 for future reference.

gkellogg commented 3 years ago

Why was this removed from the status section?

Alternatively, you can send comments to our mailing list. Please send them to public-json-ld-wg@w3.org ( archives ). Please see the Working Group's implementation report .

I do not think we should do this, at least not in this change. Such a change would require a WG resolution.

ReSpec needed me to replace the wg* configuration variables, that would have included the mailing list with a “group” variable that takes the information from the WG info (someplace). Perhaps something is missing there. I can look into the ReSpec source to try to find this.

Once this is merged, I think it would be good to record the reference of the change in the original errata comment, so that it stays on record in the generated errata.

Not sure specifically what should be referenced, or where it should go.

iherman commented 3 years ago

Not sure specifically what should be referenced, or where it should go.

Issue #364 is now an official erratum, listed in https://w3c.github.io/json-ld-syntax/errata/. If, once this is all merged, there is a comment added to that erratum with a 'Summary:', that becomes part of the errata page. That is what I was referring to.

gkellogg commented 3 years ago

I added back the wgPublicList, and ReSpec didn't complain. The sentence came back; It seems to me that it should have picked it up automatically, but I can't see the code responsible for doing this.

gkellogg commented 3 years ago

@iherman also note that the processVersion was ignored, it was 2018. It's now using the 2020 process; can we use this without WG action? It's set automatically,, so I can't really override it.

gkellogg commented 3 years ago

Sorry @TallTed I was too quick, I'll merge your changes into master.