w3c / largest-contentful-paint

Specification for the LargestContentfulPaint API

https://w3c.github.io/largest-contentful-paint/

Other

88 stars 16 forks source link

Update README.md for video #119

Open tunetheweb opened 10 months ago

clelland commented 10 months ago

83 and #85 are still open, while I write up the spec changes for this -- should we coordinate the spec + explainer changes, or do you think it's worth updating the explainer even when the spec doesn't account for animated content at all?

tunetheweb commented 10 months ago

Yeah I was thinking about that (and checked the spec to see if it needed updating too). The spec doesn’t mention video elements at all whereas the README does but with poster (which is now out of date).

Similarly, only the README mentions “fully loaded” which is now also outdated.

But agree it’s less than ideal the spec doesn’t cover this so could understand not wanting to merge this. Or could change it to be more vague but still not be wrong? Or closer to the spec and update later.

WDYT?

clelland commented 10 months ago

The spec only includes it by reference to element-timing, when it says "The Largest Contentful Paint API will only expose element types that are already exposed by the Element Timing API." -- that spec includes video poster images.

That said, I have a refactor of this spec, as well as Element Timing and Paint Timing, which I hope to land soon, to resolve a bunch of inappropriate spec layering, and we should be able to land this with it.