search

w3c / ldp-testsuite

(UNMAINTAINED) Tests for Linked Data Platform (LDP)
Other
22 stars 29 forks source link

Use SkipException instead of System.out.println() in test setup #190

Closed ja-fra closed 9 years ago

ja-fra commented 9 years ago

IMHO it would be the right approach to throw a SkipException() instead of writing warnings to System.err if the resource to test cannot be created.

Maybe it is even better to fail the test if the setup could not be completed?

spadgett commented 9 years ago

@ja-fra We had some issues where errors were not reported with failed assertions during setup, so switched to System.err.println(). See #153 and commit e8a4e06c. SkipException might be OK though since it's an Exception and not an Error. Can you verify that errors are properly reported if setup fails?

sspeiche commented 9 years ago

Closing PR as @spadgett explained why in previous comment and haven't seen any update from @ja-fra Please resubmit updated PR if you can elaborate on why this change is needed.