w3c / longtasks

Long Task API
https://w3c.github.io/longtasks/
Other
247 stars 32 forks source link

Fix containerType for tasks without culprit #72

Closed npm1 closed 5 years ago

npm1 commented 5 years ago

Currently, the longtasks spec uses 'Culprit browsing context container' to identify the browsing context container that caused a long task, when there is a single one that can be pointed at. This PR fixes containerType by setting it to 'window' when no single iframe is found to be the culprit of a longtask. It also replaces some nulls with empty strings because the attributes are not nullable. Fixes https://github.com/w3c/longtasks/issues/61


:boom: Error: 400 Bad Request :boom:

PR Preview failed to build. (Last tried on Oct 10, 2019, 2:50 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs. :link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fw3c%2Flongtasks%2F6bd51d58fde137245ed6186331bfc691510b733d%2Findex.bs&md-warning=not%20ready) ``` Error running preprocessor, returned code: 1. FATAL ERROR: Multiple local 'attribute' <dfn>s for 'TaskAttributionTiming' have the same linking text 'containerName'. ✘ Did not generate, due to fatal errors ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/longtasks%2372.)._
npm1 commented 5 years ago

Build failure seems to be caused by https://github.com/tabatkins/bikeshed/issues/1536