search

w3c / manifest-app-info

Web App Manifest - Application Information
https://w3c.github.io/manifest-app-info/
Other
28 stars 13 forks source link

consider ranaming "platform" #55

Closed philloooo closed 2 years ago

philloooo commented 2 years ago

"platform" is also used in the manifest spec and has different semantics.

"narrow" or "wide" also isn't exactly a platform.

How about renaming it to "target"? Or any other better suggestions here?

philloooo commented 2 years ago

@aarongustafson what do you think?

tomayac commented 2 years ago

How about "form_factor"?

philloooo commented 2 years ago

that sounds better than platform, @dominickng WDYT?

dominickng commented 2 years ago

form_factor is definitely better than platform. :)

aarongustafson commented 2 years ago

My original thought had been to have "narrow" and "wide" as generic platform values that could represent a class of platforms.

I’m not against introducing a form_factor key but that does increase the complexity a little. Following that line of thought, we could disambiguate to platform for the OS and form_factor for the rendering. I think there’s merit in both, especially if there are differences, but at the same time, I do tend to favor simplicity.

philloooo commented 2 years ago

I think disambiguate to platform for OS and form_factor for rendering is better.

then IMO platform is kind of an anti-pattern for the manifest though, as we don't want to encourage developers to tailor their manifest for specific OS. Following this nice design philosophy doc from Matt - https://docs.google.com/document/d/1jn_qDJEWJTyCSt3uICYjXPWJaa5z-7HhfCRPQQ_sT78/edit#heading=h.mansal90qiqr

What about introducing form_factor for "narrow" and "wide", and separately considering removing platform?

aarongustafson commented 2 years ago

@philloooo I’m into it. Feel free to submit two PRs for this.