search

w3c / media-source

Media Source Extensions
https://w3c.github.io/media-source/
Other
268 stars 57 forks source link

Unecessary argument provided to Append Error Algorithm #159

Closed jyavenard closed 7 years ago

jyavenard commented 7 years ago

https://w3c.github.io/media-source/index.html#sourcebuffer-append-error

Set 5 states: "If decode error is true, then run the end of stream algorithm with the error parameter set to "decode"."

the Append Error Algorithm is always called with the decode error parameter set to true.

Step 5 should be removed and replace the nine instances stating "run the append error algorithm with the decode error parameter set to true" (every instance referring to the append error algorithm) with "run the append error algorithm"

wolenetz commented 7 years ago

That's true. The (currently removed) appendStream had a case which IIRC exercised the append error algorithm differently.

This looks editorial in nature, not blocking v1 if it doesn't get fixed.

Thanks for reporting this issue.

On Sep 11, 2016 4:33 AM, "Jean-Yves Avenard" notifications@github.com wrote:

https://w3c.github.io/media-source/index.html#sourcebuffer-append-error

Set 5 states: "If decode error is true, then run the end of stream algorithm with the error parameter set to "decode"."

the Append Error Algorithm is always called with the decode error parameter set to true.

Step 5 should be removed and the replace the nine instances stating "run the append error algorithm with the decode error parameter set to true" (every instance referring to the append error algorithm) with "run the append error algorithm"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/w3c/media-source/issues/159, or mute the thread https://github.com/notifications/unsubscribe-auth/ALCtw6kqB3TVVutpOqd2N_p4gxNcVmEWks5qo-cjgaJpZM4J5_NB .

wolenetz commented 7 years ago

@jdsmith3000 @mwatson2 We currently have some redundant verbiage in the spec: since we've removed appendStream(), the error parameter to the append error algorithm is now always true.

@plehegar @paulbrucecotton: Would fixing an editorial-only issue like this require both regeneration of the PR spec, as well as re-requesting CfC? Please help us understand if we need to just punt this to VNext.

paulbrucecotton commented 7 years ago

I believe this change can be made editorially after the CfC closes but BEFORE we sent the transition request.

jdsmith3000 commented 7 years ago

I agree this should be corrected for V1 if at all possible and is completely editorial.