search

w3c / media-source

Media Source Extensions
https://w3c.github.io/media-source/
Other
267 stars 59 forks source link

Upstream codec switching (changeType) feature from WICG incubation spec #274

Closed wolenetz closed 3 years ago

wolenetz commented 3 years ago

Merges remote-tracking branch 'wicg-upstream/codec-switching' Pulls in the incubated codec-switching, aka changeType, specification from WICG fork. Strips out incubation boilerplate and unrelated pieces from the downstream codec-switching branch, and updates to the recently applied respec shorthand in upstream. The net result is that only media-source-respec.html is updated. Multiple user agents have shipped this feature already, and web-platform tests already exist for it. See w3c/mediasource/issues/155 (#155).

Preview | Diff

wolenetz commented 3 years ago

@tidoust - please review for respec and process correctness. Specifically, I used git merge to pull in the full downstream WICG incubation branch for this feature -- should the result, once through review, be landed in a different manner than "Squash and merge" to preserve more of the git history details? Also, while I did most of the editorial work for the feature in the WICG branch, there were a few other contributors -- if squashed when landing this, how can they be credited in that landed commit?

@mwatson2 - this is a nontrivial feature addition to MSE. It has already been implemented and shipped in multiple user agents according to the incubation spec, so hopefully isn't controversial, but please do a co-editor review pass on this.

Thank you both!

wolenetz commented 3 years ago

@mwatson2 - please review this PR as co-editor. @tidoust - please update on whether or not this may land without @mwatson2 reviewing it (in case the review continues to be delayed), as it forms the substantial basis of MSE v2 FPWD. Thank you.

mwatson2 commented 3 years ago

@wolenetz Looks good to me. Sorry for the delay.