w3c / media-source

Media Source Extensions
https://w3c.github.io/media-source/
Other
267 stars 59 forks source link

Editorial: Modernize to use internal slots instead of "internal ... variable" #286

Closed wolenetz closed 2 years ago

wolenetz commented 2 years ago

As @tidoust noted in a recent review comment (https://github.com/w3c/media-source/pull/282#discussion_r664101655), internal slots are how specs currently describe internal object variable state that is meaningful to the spec.

The existing MSE spec has a few of these which need updating (SourceBuffer append state is just one example).

wolenetz commented 2 years ago

work-in-progress so far:

Note: track buffers, track buffer and their internal state (last decode timestamp, etc) are not part of this initial refactor since this information is even less visible to the API user. This bug eventually may expand to include them though.

wolenetz commented 2 years ago

For further refactoring, see potentially #259 and #297 - Edited to fix typo (s/257/297)