Editorial: Address accessibility concerns

w3c / media-source

Media Source Extensions

https://w3c.github.io/media-source/

Other

267 stars 59 forks source link

Editorial: Address accessibility concerns #309

Closed tidoust closed 2 years ago

tidoust commented 2 years ago

This addresses some of the accessibility concerns raised in #307.

Changes:

Provide two separate columns headers for enumeration description tables and add a caption
Make parameter names row headers in parameter definition tables
Pull back old custom styles for parameter definition tables that are no longer provided out of the box by ReSpec

Preview | Diff

wolenetz commented 2 years ago

@tidoust: This looks good to me. I'm prepared to squash and merge it, but am concerned that the updated mse.css may not auto-publish.

wolenetz commented 2 years ago

@tidoust: This looks good to me. I'm prepared to squash and merge it, but am concerned that the updated mse.css may not auto-publish.

Inspecting the publishing config, it looks like the updated mse.css indeed should auto-publish (it's not excluded) - https://github.com/w3c/media-source/blob/267bf26a48b00b3d707083d19c7012c27e5c9133/.github/workflows/ci.yml#L51

I'll squash and merge it now.

matatk commented 2 years ago

Thanks for working on this, and all of the other accessibility improvements @tidoust! Overall it's great, but I noticed a couple of things I noticed (let me know if I should file a separate issue—actually I may be able to go directly to making a PR late next week if that's more helpful to you)...

I should've probably suggested row headers in the enumeration description tables; they're not huge tables, but it does make it slightly simpler to navigate with the row headers.
The <th> elements in the parameter tables need scope="row" in order to be robustly recognised as row headers.