search

w3c / media-source

Media Source Extensions
https://w3c.github.io/media-source/
Other
268 stars 57 forks source link

Change from TrackDefault.kinds to TrackDefault.getKinds #94

Closed plehegar closed 8 years ago

plehegar commented 8 years ago

Fix for #91

wolenetz commented 8 years ago

LGTM. Editorial changes (non-substantive) may follow. Thanks for putting this together, @plehegar I'll merge it shortly.

jdsmith3000 commented 8 years ago

Late, but LGTM too.

What's the status of @wolenetz's proposed addition to the at risk features here?

jdsmith3000 commented 8 years ago

Actually, two questions:

  1. How do we tell the returned value for getKinds() is a kindsobject?
  2. Is the legacy constructor entry for sequence<DOMString> kinds a bug?
[ Constructor (TrackDefaultType type, DOMString language, DOMString label, sequence<DOMString> kinds, optional DOMString byteStreamTrackID = "")]
interface TrackDefault {
    readonly        attribute TrackDefaultType type;
    readonly        attribute DOMString        byteStreamTrackID;
    readonly        attribute DOMString        language;
    readonly        attribute DOMString        label;
    sequence<DOMString> getKinds ();
};
wolenetz commented 8 years ago

Are either of those substantive? Or can we discuss and fix after today's deadline?

On Jun 9, 2016 4:08 PM, "jdsmith3000" notifications@github.com wrote:

Actually, two questions:

  1. How do we tell the returned value for getKinds() is a kindsobject?
  2. Is the legacy constructor entry for sequence kinds a bug?

[ Constructor (TrackDefaultType type, DOMString language, DOMString label, sequence kinds, optional DOMString byteStreamTrackID = "")] interface TrackDefault { readonly attribute TrackDefaultType type; readonly attribute DOMString byteStreamTrackID; readonly attribute DOMString language; readonly attribute DOMString label; sequence getKinds (); };

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/w3c/media-source/pull/94#issuecomment-225053211, or mute the thread https://github.com/notifications/unsubscribe/ALCtw09C2Cjj1paT7GSg75jAXlEHbQ8yks5qKJz8gaJpZM4IyUO8 .