search

w3c / mediacapture-extensions

Extensions to Media Capture and Streams by the WebRTC Working Group
https://w3c.github.io/mediacapture-extensions/
Other
19 stars 15 forks source link

Rename deliveredFrames to deliverableFrames #111

Closed henbos closed 1 year ago

henbos commented 1 year ago

Fixes #109

"Delivered frames" sounds like a counter that only goes up if a sink was connected that was ready to receive the frame, but the definition of the counter is "if it either was delivered to a sink or would have been delivered to a sink, if one was connected". So renaming this might make it more clear that this is about if the frame is a keeper or not, independently if sinks are connected

Preview | Diff

henbos commented 1 year ago

I feel like abandoning this PR and issue because "deliveredFrames" fits better with "discardedFrames" and I'm not sure "deliverable" is less confusing... you could think of any frame as deliverable to start with, the question is what happened to it, so past tense (delivered) may make as much sense as deliverable