search

w3c / mediacapture-extensions

Extensions to Media Capture and Streams by the WebRTC Working Group
https://w3c.github.io/mediacapture-extensions/
Other
19 stars 15 forks source link

Migrate capture metrics from RTCAudioSourceStats to MediaStreamTrack method #96

Closed henbos closed 10 months ago

henbos commented 1 year ago

The RTCAudioSourceStats contains capture related metrics that are better suited for a MediaStreamTrack method than RTCPeerConnection.getStats() since you may be capturing for a non-WebRTC context.

This was covered in the April 18, 2023 Virtual Interim and the Working Group input was supportive: Moving them to the track is the right direction, and no strong opinions on the name of the method.

There was even preference to rename track.getFrameStats() to track.getStats() expressed and this would be a good opportunity to do so, before the video capture stats are implemented.

Original issue over on the WebRTC stats spec: https://github.com/w3c/webrtc-stats/issues/741

henbos commented 1 year ago

The new version of the PR is #117

henbos commented 11 months ago

From the October interim minutes, conclusion: "Overall approach makes sense, flesh out the details in the editors meeting"

henbos commented 11 months ago

Let's not close this issue until #119 has been resolved, latency metrics also need to move (and have been approved by multiple Virtual Interim meetings)

henbos commented 11 months ago

119 was updated to only cover the current latency. So we need #128 too for complete coverage.

henbos commented 10 months ago

All PRs have now merged so it would be safe to remoev the capture metrics from RTCAudioSourceStats now. Closing this one and following up on webrtc-stats