search

w3c / mediacapture-extensions

Extensions to Media Capture and Streams by the WebRTC Working Group
https://w3c.github.io/mediacapture-extensions/
Other
19 stars 14 forks source link

Add audio capture stats, rename method to getStats. #97

Closed henbos closed 9 months ago

henbos commented 1 year ago

Fixes #96.

Preview | Diff

henbos commented 1 year ago

This is approximately just a move, but instead of talking about "audio samples" I've rephrased it to match the terminology that is used outside of webrtc-stats to say "audio frames" instead. I've also added a clarifying note.

jan-ivar commented 1 year ago

Editors can integrate pending approval from @padenot.

henbos commented 1 year ago

If this merges we'll delete the corresponding ones from RTCPeerConnection.getStats and implement this instead

jan-ivar commented 1 year ago

@dontcallmedom can we add @padenot as a reviewer in this repo? I don't seem to have the powers.

jan-ivar commented 1 year ago

Paul had valuable feedback and should be able to comment tomorrow.

jan-ivar commented 1 year ago

I've filed #98 with Paul's concerns.

henbos commented 1 year ago

98 is about async versus sync, not about the metrics added in this PR. Can we follow up on the API shape separately from the addition of these metrics? Can I merge the PR?

henbos commented 1 year ago

https://github.com/w3c/mediacapture-extensions/issues/98 is about async versus sync, not about the metrics added in this PR. Can we follow up on the API shape separately from the addition of these metrics? Can I merge the PR?

Ping @jan-ivar

henbos commented 10 months ago

This PR is obsolete. I will close it once I have a synchronous version of the proposal and other PRs have landed. Iceboxed in the meantime

henbos commented 9 months ago

Closing this one, will upload a new version which follows the new API pattern and rephrases things a bit