search

w3c / mediacapture-image

Mediastream Image Capture
https://w3c.github.io/mediacapture-image/
Other
74 stars 40 forks source link

PhotoCapabilities::autoWhiteBalanceMode is a MediaSettingsItem, could be boolean #14

Closed yell0wd0g closed 8 years ago

yell0wd0g commented 8 years ago

In [1] , autoWhiteBalanceMode is described as:

This reflects whether automated White Balance Mode selection is on or off, and is boolean - on is true

So I would propose making it Boolean instead of MediaSettingsItem.

The equivalent autoWhiteBalanceMode setting in PhotoSettings [2] is a boolean.

[1] http://w3c.github.io/mediacapture-image/index.html#attributes-4 [2] http://w3c.github.io/mediacapture-image/index.html#dictionary-photosettings-members

yell0wd0g commented 8 years ago

Same thing for redEyeReduction in the same interface.

gmandyam commented 8 years ago

Yes, these should be Boolean types. Thanks for the catch. Have incorporated PR.