w3c / mediacapture-output

API to manage the rendering of audio on any audio output device
https://w3c.github.io/mediacapture-output/
Other
26 stars 25 forks source link

Define "speaker-selection" powerful feature types and algorithms. #128

Closed miketaylr closed 2 years ago

miketaylr commented 2 years ago

As part of https://github.com/w3c/permissions/issues/263, we're moving each powerful feature to be defined in its parent spec, rather than treat Permissions as a registry.

(also, https://github.com/w3c/permissions/issues/320)

cc @marcoscaceres


Preview | Diff


:boom: Error: 500 Internal Server Error :boom:

PR Preview failed to build. (Last tried on Feb 10, 2022, 6:35 PM UTC).

More PR Preview relies on a number of web services to run. There seems to be an issue with the following one: :rotating_light: [Spec Generator](https://www.w3.org/2015/labs/) - Spec Generator is the web service used to build specs that rely on ReSpec. :link: [Related URL](https://labs.w3.org/spec-generator/?type=respec&url=https%3A%2F%2Frawcdn.githack.com%2Fmiketaylr%2Fmediacapture-output%2F932592cf3d8580d7609683d445ad0e246cf94c8b%2Findex.html%3FisPreview%3Dtrue) ``` šŸ“” HTTP Error 429: https://rawcdn.githack.com/miketaylr/mediacapture-output/932592cf3d8580d7609683d445ad0e246cf94c8b/index.html ``` _If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20w3c/mediacapture-output%23128.)._
miketaylr commented 2 years ago

error respec@28.0.3: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.18.1" error Found incompatible module.

@sidvishnoi is this related to https://github.com/w3c/spec-prod/issues/99?

dontcallmedom commented 2 years ago

the problem was that this repo was using an outdated version of spec-prod - if you rebase on top of https://github.com/w3c/mediacapture-output/commit/87253eaadffafe82dcb2b56e3675caaab5e7b516 the error should be gone

sidvishnoi commented 2 years ago

@miketaylr Please upgrade to spec-prod@v2 (See https://github.com/w3c/spec-prod/issues/99#issuecomment-964432761) (just a few seconds late šŸ˜„)

miketaylr commented 2 years ago

the problem was that this repo was using an outdated version of spec-prod - if you rebase on top of 87253ea the error should be gone

Cool, thanks @dontcallmedom (and @sidvishnoi)

dontcallmedom commented 2 years ago

@jan-ivar given that this permission is common to Media Capture and Streams, and that generally speaking that is where most of the privacy/permission framework is defined, my sense is that this would better be integrated there than in Audio Output - do you agree?

miketaylr commented 2 years ago

I plan on making a similar PR to Media Capture and Streams, to do the same thing for "camera" and "microphone". If y'all would prefer that all 3 live in the same spot, works for me.

dontcallmedom commented 2 years ago

I guess my point of Media Capture and Streams was more specifically about the IDL bits (which presumably should only live in a single place)

jan-ivar commented 2 years ago

Agree.

jan-ivar commented 2 years ago

To clarify, the non-webidl bits (Permissions Integration) in this PR specific to "speaker-selection" seem fine to leave here.

miketaylr commented 2 years ago

OK, I've pulled out the IDL and will work on a PR for mediacapture-main. It's probably good to land them together.

miketaylr commented 2 years ago

@jan-ivar is this one fine to land as well, or is something blocking/missing?

miketaylr commented 2 years ago

@jan-ivar is this one fine to land as well, or is something blocking/missing?

Friendly happy new years ping, @jan-ivar :)

miketaylr commented 2 years ago

@dontcallmedom who is the best person to review this? It would be nice to get it merged.

miketaylr commented 2 years ago

Thanks for doing this integration work, and sorry for the delay!

No worries, life gets busy. :) The prose was just moved over from the Permissions spec and not authored by me. Not entirely sure of the history there, but let's see if we can't improve it.

jan-ivar commented 2 years ago

I'm committing with those changes. Let's get this merged.

miketaylr commented 2 years ago

I'm committing with those changes. Let's get this merged.

Awesome - thanks!

jan-ivar commented 2 years ago

(for some reason my suggestion in https://github.com/w3c/mediacapture-output/pull/128#discussion_r803988235 didn't take, so I pushed that as a manual follow-up)